Does it matter if I get a 38mm or 42mm Apple Watch for use with ForeFlight?

No, the functionality of the 38mm and 42mm Apple Watch are the same.  You can get which ever size you prefer.